RFR(M): 8068883: Remove disabling of warning "C4355: 'this' : used in base member initializer list"

Volker Simonis volker.simonis at gmail.com
Mon Feb 16 09:42:59 UTC 2015


On Mon, Feb 16, 2015 at 8:59 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> On Jan 14, 2015, at 3:50 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>
>> On Jan 14, 2015, at 11:28 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
>>>>> I've additionally also removed the Visual Studio compiler macro which
>>>>> disable the warning "C4786:'identifier' : identifier was truncated to
>>>>> 'number' characters in the debug information." because as far as I
>>>>> could see, this was only relevant up to Visual Studio 6.0 and I hope
>>>>> nobody will ever compile the HotSpot with that compiler any more(see
>>>>> http://support.microsoft.com/kb/195386).
>>>>
>>>> This seems like a worthwhile change, independent of the other changes
>>>> being proposed.  Could this be separated out.
>>>>
>>>
>>> Sure, if we decide not to push this patch we can still just remove
>>> that pragma in a separate change.
>>
>> […] If you (Volker) don't want
>> to deal with the extra overhead, I'll take care of it.
>
> Finally getting around to following up on this bit of the discussion.
>
> https://bugs.openjdk.java.net/browse/JDK-8073188
>
> So it might get cleaned up eventually.
>

Thanks! I'll be happy to review it once you send around a RFR.

Regards,
Volker


More information about the hotspot-gc-dev mailing list