RFR: 8073464 - GC workers do not have thread names

Thomas Schatzl thomas.schatzl at oracle.com
Fri Feb 20 15:01:30 UTC 2015


Hi,

On Fri, 2015-02-20 at 14:39 +0100, David Lindholm wrote:
> Hi,
> 
> Please review this small fix in GangWorker:initialize(). This addition 
> sets the native thread names of GangWorker threads, which the GC uses 
> for worker threads. Now these names will be visible when debugging in GDB.
> 
> Webrev: http://cr.openjdk.java.net/~stefank/0thers/david/8073464/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8073464
> 

  please use Thread::set_native_thread_name() instead of the os function
directly.

Also, wouldn't it be much more useful to set the native thread name for
all NamedThreads to the name that is passed via set_name() by default?
This would prevent us from doing this work multiple times.

You might also fix the names themselves for gc owned threads in this CR.
I do not see the need to split this up in CRs per thread type with each
CR being a one-line change.

Thanks,
  Thomas
 



More information about the hotspot-gc-dev mailing list