RFR (L): 8058354: SPECjvm2008-Derby -2.7% performance regression on Solaris-X64 starting with 9-b29

Jon Masamitsu jon.masamitsu at oracle.com
Fri Feb 20 15:17:39 UTC 2015


On 2/17/2015 12:35 AM, Thomas Schatzl wrote:
> Hi all,
>
> On Tue, 2015-02-03 at 10:32 -0800, Jon Masamitsu wrote:
>> On 02/03/2015 02:27 AM, Thomas Schatzl wrote:
>>> Hi Jon,
>>>
>>>     thanks for the comments. I incorporated all of them in the latest
>>> webrev at
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8058354/webrev.1/ (full)
>>> http://cr.openjdk.java.net/~tschatzl/8058354/webrev.0_to_1/ (diff)
> That webrev contains a bug that I found shortly after, the roundto()
> method just rounds but does not divide :/ Please re-review the fix for
> that.
>
> After fixing this I went through another big round of testing (perf +
> lots of aurora tests) to make sure that the change is finally good.
>
> Here are the changesets:
>
> http://cr.openjdk.java.net/~tschatzl/8058354/webrev.2/ (full)
> http://cr.openjdk.java.net/~tschatzl/8058354/webrev.1_to_2/ (diff)

That last change looks fine

Reviewed.

Jon

>
> Sorry for the issues,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list