RFR (S): 8073466: Remove buffer retaining functionality and clean up in ParGCAllocBuffer

Kim Barrett kim.barrett at oracle.com
Mon Feb 23 16:50:15 UTC 2015


On Feb 23, 2015, at 6:53 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> On Mon, 2015-02-23 at 00:40 -0500, Kim Barrett wrote:
>> ------------------------------------------------------------------------------  
>> src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp
>> 148   void reset() {
>> 149     _allocated = 0;
>> 150     _wasted    = 0;
>> 151     _unused    = 0;
>> 152   }
>> 
>> This new private helper function seems to only be used in the one
>> place at the end of adjust_desired_plab_sz, where equivalent code used
>> to be inline.  I'm not sure making a helper function is actually
>> beneficial here.  The code that actually uses those variables is
>> earlier in the function.  Moving the reinitialization far away (and
>> losing the comment about clearing the accumulators) doesn't seem
>> helpful to me.
>> 
> 
> I have around 7-8 patches building on that. The second, for JDK-8073013,
> makes that method virtual since I am going to make special PLAB
> statistics for G1.

OK.

> New webrevs at
> http://cr.openjdk.java.net/~tschatzl/8073466/webrev.1/
> http://cr.openjdk.java.net/~tschatzl/8073466/webrev.0_to_1/

Looks good.



More information about the hotspot-gc-dev mailing list