RFR(XS): JDK-8073883 - serviceability/dcmd/gc/RunGCTest.java should not run with -XX:+ExplicitGCInvokesConcurrent

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Feb 26 13:15:17 UTC 2015


Thanks Mikael!

I agree with the small change classification and will push this in a few hours 
if there are no complaints.
/Jesper

Mikael Gerdin skrev den 26/2/15 13:41:
> Hi Jesper,
>
> On 2015-02-26 13:34, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> Please review this minor fix to add -XX:-ExplicitGCInvokesConcurrent to
>> this test. The test expects messages from a full GC and will not work if
>> ExplicitGCInvokesConcurrent is enabled.
>>
>> This is a critical nightly issue (since it causes the test to fail often
>> enough).
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8073883
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8073883/webrev.00/
>
> The fix looks good.
> I'd classify this as a small change and I don't think you need to wait 24h
> before integrating the fix.
>
> /Mikael
>
>>
>> Thanks,
>> /Jesper


More information about the hotspot-gc-dev mailing list