3rd rev: RFR: 8066821(S) Enhance command line processing to manage deprecating and obsoleting -XX command line arguments

Derek White derek.white at oracle.com
Thu Jan 22 19:05:20 UTC 2015


Put together another webrev with changes listed below: 
http://cr.openjdk.java.net/~drwhite/8066821/webrev.03/

jtreg and jprt run.

  - Derek

  On 1/21/15 10:05 AM, Oracle wrote:
> Thanks Gerard,
>
>
> On Jan 20, 2015, at 6:59 PM, Gerard Ziemski <gerard.ziemski at oracle.com 
> <mailto:gerard.ziemski at oracle.com>> wrote:
>
>> hi Derek ,
>>
>> Very, very nice code and thank you for taking the time to do a bit of code cleanup. I have just a few comments/suggestions below for the “arguments.cpp" file:
>>
>> #1 Instead of
>>
>>     { "MaxGCMinorPauseMillis", JDK_Version::jdk(8), JDK_Version::jdk(SpecialFlag::_removal_unscheduled)},
>>
>> how about this:
>>
>>     { "MaxGCMinorPauseMillis", JDK_Version::jdk(8), JDK_Version::jdk(JDK_Version::unscheduled())},
>>
>> and move "bool is_removal_scheduled() const” API to JDK_Version class? It seems to me that any API that has to do with JDK version number should live in JDK_Version class.
>
> How about "JDK_Version::undefined()" instead? That seems more 
> generally useful and less option-specific
>> #2 Instead of
>>
>>     .
>>     .
>>     .
>>     { "CMSMarkStackSizeMax", JDK_Version::jdk(9), JDK_Version::jdk(10)},
>>     { "CMSMarkStackSize", JDK_Version::jdk(9), JDK_Version::jdk(10)},
>>     .
>>     .
>>     .
>>
>> how about going back to the nice formatting we used to have like:
>>
>>     .
>>     .
>>     .
>>     { "CMSMarkStackSizeMax”,	JDK_Version::jdk(9), JDK_Version::jdk(10)},
>>     { "CMSMarkStackSize”,	JDK_Version::jdk(9), JDK_Version::jdk(10)},
>>     .
>>     .
>>     .
>>
>> The formatted text seems so much nicer to read.
>
> OK. I thought I did that. Must have gotten lost.

My IDE snuck in and "fixed" the formatting. Somehow I didn't notice!

Thanks,

   - Derek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150122/fe99b103/attachment.html>


More information about the hotspot-gc-dev mailing list