RFR: JDK-8068589: GCCause should distinguish jcmd GC.run from System.gc()

Staffan Larsen staffan.larsen at oracle.com
Mon Jan 26 08:12:57 UTC 2015


A bit of terminology here. ‘GC.run’ is called a ‘Diagnostic Command’. ‘jcmd’ is one way to invoke a Diagnostic Command. Another way is via a JMX MBean. With this in mind I think your references to ‘jcmd’ should be changed to ‘diagnostic command’ (or an abbreviation thereof). For example: _jcmd_gc_run -> _dcmd_gc_run.

Thanks,
/Staffan

> On 25 jan 2015, at 14:15, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> 
> Hi all,
> 
> GCCause which is printed in gc log is "System.gc()" when jcmd GC.run is invoked. 
> I think that GCCause which is caused by jcmd GC.run should be different from System.gc() . 
> 
> I uploaded webrev for this enhancement:
> http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.00/
> 
> This patch prints "jcmd GC.run" to gc log when jcmd GC.run is invoked. 
> 
> 
> Could you review it?
> 
> 
> Thanks,
> 
> Yasumasa



More information about the hotspot-gc-dev mailing list