RFR (XS): 8071805: BarrierSet::Other is not used and should be removed. [Was: Re: Review request:]

joe provino joseph.provino at oracle.com
Thu Jan 29 15:01:10 UTC 2015


Will do!  Thanks.



On 01/29/2015 03:17 AM, Thomas Schatzl wrote:
> Hi Joe,
>
> On Wed, 2015-01-28 at 18:06 -0500, Joseph Provino wrote:
>> Please review this VERY small change.
>>
>> All occurrences of BarrierSet::Other have been removed
>> and "Other" has been removed from enum Name in barrierSet.hpp.
>>
>> I also need a sponsor to push the change.
>>
>> Webrev and bug report are here:
>>
>> http://cr.openjdk.java.net/~jprovino/8071805/webrev.00
>>
>> https://bugs.openjdk.java.net/browse/JDK-8071805
>    looks good.
>
> Could you please improve the subject line for the next review request?
>
> We typically use the format:
>
> "RFR (" <size> "): " <cr> ": "<description>
>
> where
>
>    <size> is one of XXS, XS, S, M, L, XL, XXL; this is an estimate of the
> time to review, i.e. amount of change and complexity.
>
>    <cr> is the CR number
>
>    <description> is the short description from the CR.
>
> E.g. in this case it should look like:
>
>    RFR (XS): 8071805: BarrierSet::Other is not used and should be
> removed.
>
> This would help us a lot organizing them, and make sure that nothing
> slips through.
>
> I can sponsor the change.
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list