RFR: 8130931: refactor CardTableModRefBS[ForCTRS]

Kim Barrett kim.barrett at oracle.com
Mon Jul 20 21:35:08 UTC 2015


On Jul 20, 2015, at 4:32 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> On Mon, 2015-07-20 at 02:27 -0400, Kim Barrett wrote:
>> On Jul 13, 2015, at 4:47 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>> 
>>> On Fri, 2015-07-10 at 20:23 -0400, Kim Barrett wrote:
>>>> Please review this refactoring of CardTableModRefBS and
>>>> CardTableModRefBSForCTRS.  The changes are in two stages, with
>>>> separate webrevs to make it easier to review.
>>>> 
>>>> The first stage eliminates some friend declarations from
>>>> CardTableModRefBS.
>>>> 
>>>> - BytecodeInterpreter doesn't need to be a friend.
>>>> - CheckForUnmarkedOops changed to use public byte_for_const().
>>> 
>>> Actually the whole member _unmarked_card can be removed.
>> 
>> Good point. Here’s the diff for that change.  I can produce a new webrev if needed.
> 
> Please do. You do need a second reviewer, not sure if he will want to
> dig through all the thread emails to get every bit of the change…



> 
> [...]
> 
>>> I would prefer if the parCardTableModRefBS.cpp file would be removed,
>>> its contents moved to the new CardTableModRefBSForCTRS.cpp as it only
>>> contains CardTableModRefBSForCTRS methods (and both seem only used for
>>> CMS).
>>> Iow, is there some reason to keep this file, or is this part of the
>>> "left for later" task?
>> 
>> Yes, this is part of the “left for later” task.  I don’t want to move those functions
>> from one file to another, only to later have them moved (more or less) back.
> 
> Okay.
> 
> Thanks,
>  Thomas




More information about the hotspot-gc-dev mailing list