RFR: 8130931: refactor CardTableModRefBS[ForCTRS]

Mikael Gerdin mikael.gerdin at oracle.com
Tue Jul 21 12:09:08 UTC 2015


Hi Kim,

On 2015-07-20 23:40, Kim Barrett wrote:
> [Sorry about the earlier content-free reply.  Accidentally sent while still composing.]
>
> On Jul 20, 2015, at 4:32 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>> On Mon, 2015-07-20 at 02:27 -0400, Kim Barrett wrote:
>>> On Jul 13, 2015, at 4:47 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>>>
>>>> On Fri, 2015-07-10 at 20:23 -0400, Kim Barrett wrote:
>>>>> Please review this refactoring of CardTableModRefBS and
>>>>> CardTableModRefBSForCTRS.  The changes are in two stages, with
>>>>> separate webrevs to make it easier to review.
>>>>>
>>>>> The first stage eliminates some friend declarations from
>>>>> CardTableModRefBS.
>>>>>
>>>>> - BytecodeInterpreter doesn't need to be a friend.
>>>>> - CheckForUnmarkedOops changed to use public byte_for_const().
>>>>
>>>> Actually the whole member _unmarked_card can be removed.
>>>
>>> Good point. Here’s the diff for that change.  I can produce a new webrev if needed.
>>
>> Please do. You do need a second reviewer, not sure if he will want to
>> dig through all the thread emails to get every bit of the change…
>
> Incremental webrev for de-friending:
> http://cr.openjdk.java.net/~kbarrett/8130931/remove-friends.01.incr/
> This removes _unmarked_card.
>
> Updated webrev for de-friending:
> http://cr.openjdk.java.net/~kbarrett/8130931/remove-friends.01/
>
> No changes to earlier refactoring webrev:
> http://cr.openjdk.java.net/~kbarrett/8130931/refactor.00/
>
> Updated full webrev:
> http://cr.openjdk.java.net/~kbarrett/8130931/webrev.01/

The change looks good to me.

/Mikael

>


More information about the hotspot-gc-dev mailing list