RFR: JDK-8132148 : G1 hs_err region dump legend out of sync with region values

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jul 23 15:18:40 UTC 2015


Hi Eric,

On Thu, 2015-07-23 at 10:46 -0400, Eric Caspole wrote:
> Hi everybody,
> The other day we noticed the legend for the G1 regions in the hs_err 
> file was out of sync with the actual values, here is a patch:
> 
>   http://cr.openjdk.java.net/~ecaspole/JDK-8132148/webrev/
> 
> For bug:
>   https://bugs.openjdk.java.net/browse/JDK-8132148
> 
> Let me know what you think.

  looks good. If we want this to be more future-proof, we might want to
poke the results of HeapRegion::get_short_str() into the output string
instead of hardcoding them.

E.g. 

("Heap Regions: (%s=young(eden), %s=young(survivor), %s=old, "
               "%s=humongous(starts), %s=humongous(continues), "
[...]
    , HeapRegion::get_short_str(HeapRegionType::EdenTag), HeapRegion::get_short_str(HeapRegionType::SurvTage), ...

etc.

It's your call, as the others are fine with just hardcoding the values.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list