RFR: 8081682: AbstractWorkGang::_terminate is never used

Kim Barrett kim.barrett at oracle.com
Tue Jun 2 23:06:02 UTC 2015


On Jun 2, 2015, at 9:51 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this patch to remove the AbstractWorkGang::_terminate variable. The work gangs are never deleted and therefore the code which sets _terminate is never executed.
> 
> http://cr.openjdk.java.net/~stefank/8081682/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8081682
> 
> Thanks,
> StefanK

I assume the idea here is that, rather than having a (presently
unused) generic early stop request mechanism provided by the workgroup
framework, any workgroup that needs an early stop mechanism should
roll its own.  Are there any that already do so, and could have been
using the generic mechanism?

The changes look ok.



More information about the hotspot-gc-dev mailing list