RFR: 8081682: AbstractWorkGang::_terminate is never used

Per Liden per.liden at oracle.com
Wed Jun 3 09:07:42 UTC 2015


On 2015-06-02 15:51, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to remove the AbstractWorkGang::_terminate
> variable. The work gangs are never deleted and therefore the code which
> sets _terminate is never executed.
>
> http://cr.openjdk.java.net/~stefank/8081682/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8081682

Change looks good.

At some point we probably want to add a tested version of stop() and 
call that e.g. from G1CollectedHeap::stop(), where we stop/terminate all 
the other threads at VM shutdown. Maybe we should create a bug for this?

cheers,
/Per


More information about the hotspot-gc-dev mailing list