RFR (XXS): JDK-8085983 G1CollectedHeap::collection_set_iterate_from() has unused code and can be simplified

Stefan Karlsson stefan.karlsson at oracle.com
Wed Jun 10 16:46:26 UTC 2015


Hi Joe,

On 2015-06-08 21:16, Joseph Provino wrote:
> One file.
>
> CR:  https://bugs.openjdk.java.net/browse/JDK-8085983
>
> webrev:  http://cr.openjdk.java.net/~jprovino/8085983/webrev.00

Some comments:

*+      guarantee(!cl->doHeapRegion(cur), err_msg("doHeapRegion() returned true"));*


- You don't need err_msg if you don't have any format specifiers in the 
error message.

- I would prefer if you didn't put the cl->doHeapReagion() calls inside 
guarantees. It's too easy to incorrectly assume that the code in the 
guarantee is only verification code, IMHO.

- Shouldn't this be an assert instead of a guarantee?

Thanks,
StefanK

>
> passes jprt.
>
> thanks.
>
> joe
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150610/cbbe81d9/attachment.html>


More information about the hotspot-gc-dev mailing list