RFR: 8079315: UseCondCardMark broken in conjunction with CMS precleaning

Erik Österlund erik.osterlund at lnu.se
Tue Jun 16 15:24:45 UTC 2015


Hi Andrew,

I¹m just an author, so my opinion probably doesn¹t matter.
However, it would be nice if you in graphKit.cpp could join the two if
statements:

L3806: if (UseConcMarkSweepGC && UseCondCardMark) {

 Šmembar stuffŠ
}

L3811: if (UseCondCardMark) {
 ŠstuffŠ
}

Šso that the code gets more readable and is consistent with how it was
done in the other 2 files.
Also, I¹m curious if you ran any benchmarks to see what happens to
performance?

Otherwise it looks good to me!

Thanks,
/Erik

Den 16/06/15 07:38 skrev Andrew Haley <aph at redhat.com>:

>On 06/14/2015 09:37 AM, Andrew Haley wrote:
>> On 14/06/15 01:25, Erik Österlund wrote:
>> 
>>> Short story:
>>> I talked to Dave Dice about my ADS implementation(s). He agrees my ADS
>>>is
>>> ³probably safe², but explained that just fencing is probably preferred
>>> over ADS for the future anyway due to current hardware trends of
>>> optimizing fences.
>> ...
>>> Therefore, let¹s go for fences! :)
>> 
>> Great, thanks very much for your work one this.
>
>OK, so, will someone please review my patch or suggest an alternative?
>
>http://cr.openjdk.java.net/~aph/8079315/
>
>Thanks,
>Andrew.
>
>



More information about the hotspot-gc-dev mailing list