Request for Review (s) - 7012980: PSOldGen is increased if there is no space in Metaspace

Jon Masamitsu jon.masamitsu at oracle.com
Thu Jun 18 16:02:44 UTC 2015


A recent integration collided with my patch so I had to merge
and redo the webrev.  Previously in addition to the fix there was
a clean up that introduce a method is_system_gc().  The need
for is_system_gc() was overridden by the already added
is_user_requested_gc().

New webrev

http://cr.openjdk.java.net/~jmasa/7012980/webrev.02/

Thanks.

Jon


On 05/20/2015 10:24 AM, Jon Masamitsu wrote:
> I'm reviving this request for review.
>
> New versions of the webrev's for review.
>
> Added should_update_eden_stats() for young gen collections
>
> http://cr.openjdk.java.net/~jmasa/7012980/webrev.fix.01/
>
> No changes from the first version.
>
> http://cr.openjdk.java.net/~jmasa/7012980/webrev.is_system_gc.01/
>
> Thanks.
>
> Jon
>
> On 5/11/2015 2:19 PM, Jon Masamitsu wrote:
>> Please put this request on hold.
>>
>> On 05/08/2015 08:58 AM, Jon Masamitsu wrote:
>>> When full collections were being done because the Metaspace 
>>> threshold was
>>> reached, the Java heap was being expanded.  Changed the test for 
>>> expanding
>>> the Java heap to check that the GCCause was for a full old gen or 
>>> for adaptive
>>> size policy which is done in anticipation that a full GC will be 
>>> needed before
>>> the next young gen collection.
>>>
>>> This change is done in two parts: the fix for this bug and a cleanup
>>> to add the GCCause::is_system_gc().  This can be pushed separately
>>> if desired.
>>>
>>> http://cr.openjdk.java.net/~jmasa/7012980/webrev.fix.00/
>>> http://cr.openjdk.java.net/~jmasa/7012980/webrev.is_system_gc.00/
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-7012980
>>>
>>> Stability tested product and debug with gc_test_suite. Performance 
>>> tested
>>> with specjbb2000 and specjbb2005 with and without MetaspaceSize set to
>>> generate some Metaspace threshold caused full GC's.
>>>
>>> Thanks.
>>>
>>> Jon
>>
>



More information about the hotspot-gc-dev mailing list