RFR (S): 8079208: gc/g1/TestLargePageUseForAuxMemory.java fails due to not considering page allocation granularity for setup

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Tue Jun 23 13:36:34 UTC 2015


Hi Thomas,

The fix looks good to me. Sorry for delay with the review.

Thanks,
Dima

On 19.06.2015 11:27, Thomas Schatzl wrote:
> Hi Dmitry,
>
> On Tue, 2015-05-19 at 15:47 +0300, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
>> The change looks good. It would look even better if the values of
>> largePageSize, smallPageSize and allocGranulairty are printed out.
>> Having their values in output will help to debug test failure.
>>
>    added lines 61/62 to the test case for that in
> http://cr.openjdk.java.net/~tschatzl/8079208/webrev.2/test/gc/g1/TestLargePageUseForAuxMemory.java.frames.html
>
> No other changes.
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8079208/webrev.2/
>
> Also the test passed Aurora testing on windows hosts with large pages
> enabled.
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list