RFR (M): 8129558: Coalesce dead objects during removal of self-forwarded pointers

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jun 25 15:30:15 UTC 2015


Hi Mikael,

  thanks for the review...

On Thu, 2015-06-25 at 15:20 +0200, Mikael Gerdin wrote:
> Hi Thomas,
> 
> On 2015-06-25 10:07, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for the first change in a set of changes that speed
> > up evacuation failure?
> >[...]
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8129558
> >
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8129558/webrev
> 
> Can you make zap_dead_objects a member function of 
> RemoveSelfForwardPtrObjClosure,
> then it will already have access to _g1 and _cm
> and then have remove_self_forward_ptr_by_...
> call a function on rspc to clear the last part of the region?
> That way the zapping functionality is nicely encapsulated and
> last_object_end doesn't need to be exposed.
> 
> Otherwise I think the change looks good and I think it's a nice step 
> towards cleaning up this code.

New webrevs at
http://cr.openjdk.java.net/~tschatzl/8129558/webrev.1 (complete)
http://cr.openjdk.java.net/~tschatzl/8129558/webrev.0_to_1 (diff)

Fixed according to your suggestions I hope - it still needs an extra
method (zap_remainer()) to hide the last_object_end.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list