RFR(XS): JDK-8071335 - gc/TestSmallHeap.java throw OOM
bengt.rutisson at oracle.com
Tue Mar 3 06:49:14 UTC 2015
On 2015-03-02 21:12, Jesper Wilhelmsson wrote:
> Please review this small change.
> The test TestSmallHeap.java is designed to make sure we can run a tiny
> application in 2MB of heap (according to the documentation this should
> work). Unfortunately when adding a specific set of flags we get an
> OOME. (For details see the bug.)
> The conclusion in the bug is to not run the test with -Xcomp. This
> change fixes that.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8071335
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8071335/webrev.00/
This seems to be the first use of vm.compMode in any test. Have you
verified that it works in the expected way?
I found an odd comment in the JTreg documentation about @requires. It says:
"The @requires tag may be used at most once in a given test."
I doubt that this is correct since we already have tests with multiple
@requires tags (even this test already has it). But it might be worth
verifying the new @requires statement actually has an effect.
If it works as expected I think this change looks reasonable.
More information about the hotspot-gc-dev