RFR: 8074319: barrier_set_cast defined via friend injection

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue Mar 3 16:37:43 UTC 2015


Thanks for fixing this!  I'm not fluid in C++ templates, but it looks good to 
me. I have verified that it builds fine with Xcode 5 using your patch.


Kim Barrett skrev den 3/3/15 17:26:
> Please review this small change to the recently added barrier_set_cast
> (see https://bugs.openjdk.java.net/browse/JDK-8069016). The way that
> new function is being defined is unintentionally not standards
> conforming and should not compile, but all of our present official
> test platforms accept it anyway. The code is presently only known to
> fail with the more recent Xcode6.
> I will need a sponsor for this change.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8074319
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8074319/webrev.00/

More information about the hotspot-gc-dev mailing list