RFR (XS): Wrong volatile qualifier for field ClassLoaderDataGraphKlassIteratorAtomic::_next_klass
stefan.karlsson at oracle.com
Mon Mar 9 07:47:58 UTC 2015
On 06/03/15 17:17, Siebenborn, Axel wrote:
> can I have some reviews for this small change.
> It fixes a serious problem as the pointer _next_klass is changed
> concurrently but not correctly declared as volatile.
> The change fixes the declaration and removes an unneeded cast.
> bug: https://bugs.openjdk.java.net/browse/JDK-8074561
> webrev: http://cr.openjdk.java.net/~asiebenborn/8074561/webrev.00/
Looks good. Thanks for finding and fixing this issue.
BTW, there might be a few more problematic places in the GC code:
https://bugs.openjdk.java.net/browse/JDK-8033552 - Fix missing missing
volatile specifiers in CAS operations in GC code
> I need a sponsor for the change.
I'll sponsor the change.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev