RFR (XS): Wrong volatile qualifier for field ClassLoaderDataGraphKlassIteratorAtomic::_next_klass

Siebenborn, Axel axel.siebenborn at sap.com
Mon Mar 9 13:00:07 UTC 2015


Mikael, Stefan,
thanks for reviews and sponsoring.

Axel

On 09/03/15 08:47 Stefan Karlsson wrote:
> Hi Axel,
>
> On 06/03/15 17:17, Siebenborn, Axel wrote:
>>
>> Hi,
>>
>> can I have some reviews for this small change.
>>
>> It fixes a serious problem as the pointer _next_klass is changed concurrently but not correctly declared as volatile.
>>
>> The change fixes the declaration and removes an unneeded cast.
>>
>>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8074561
>>
>>
>>
>> webrev: http://cr.openjdk.java.net/~asiebenborn/8074561/webrev.00/
>
> Looks good. Thanks for finding and fixing this issue.
>
> BTW, there might be a few more problematic places in the GC code:
> https://bugs.openjdk.java.net/browse/JDK-8033552 - Fix missing missing volatile specifiers in CAS operations in GC code
>>
>>
>>
>> I need a sponsor for the change.
>
> I'll sponsor the change.
>
> Thanks,
> StefanK
>>
>>
>>
>> Thanks,
>>
>> Axel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150309/6d715af7/attachment.htm>


More information about the hotspot-gc-dev mailing list