RFR: 8075247: Cleanup specialized_oop_closures.hpp

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 16 20:45:08 UTC 2015


On Mon, 2015-03-16 at 17:04 +0100, Stefan Karlsson wrote:
> Hi,
> Please review this patch to rename and simplify some macros in 
> specialized_oop_closures.hpp and g1_specialized_oop_closures.hpp.
> The patch contains the following changes:
> 1) The FURTHER_SPECIALIZED* macros are only used by G1, so they have 
> been renamed into SPECIALIZED_*G1.
> 2) Removed some unnecessary #ifdefs. The compile will catch the error if 
> we try to redefine the macro.
> 3) Gather all CMS specific macros inside a new 
> http://cr.openjdk.java.net/~stefank/8075247/webrev.01
> https://bugs.openjdk.java.net/browse/JDK-8075247

I am not completely sure why in many files touched in this change both
cpp and the corresponding hpp files include
specialized_oop_closures.hpp. Is there a particular reason to do so?


More information about the hotspot-gc-dev mailing list