RFR: JDK-8060017: Report heap sizing time

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 23 16:15:22 UTC 2015

Hi Eric,

On Thu, 2015-03-19 at 13:15 -0400, Eric Caspole wrote:
> Thanks Kim I simplified this part.
> http://cr.openjdk.java.net/~ecaspole/JDK-8060017/04/webrev/
> Eric

  - I would prefer instead of repeating the code surrounding the
expand() call to introduce a new method like expand_and_track_time() or

  - also, I would somewhat prefer to always print the "Expand Heap"
message, at least in detail level finest. Keeping current behavior is
not really a problem with me, but this would also make a test easier :)
(e.g. expand hotspot/test/gc/g1/TestGCLogMessages.java)

  - _cur_expand_heap_time_ms seems to be never initialized or reset. At
least some cursory testing with small benchmarks suspiciously reports
heap expansion times without any expansion actually occurring (e.g. heap
size staying the same, and the times themselves being always the same).


More information about the hotspot-gc-dev mailing list