RFR (S): JDK-8076076: Move SharedHeap::print_size_transition() into G1 code

Thomas Schatzl thomas.schatzl at oracle.com
Thu Mar 26 14:43:01 UTC 2015


On Thu, 2015-03-26 at 14:30 +0100, Bengt Rutisson wrote:
> Hi everyone,
> One more step towards eventually getting rid of SharedHeap.
> Could I have a couple of reviews for this small change:
> http://cr.openjdk.java.net/~brutisso/8076076/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8076076
> The method SharedHeap::print_size_transition() is only used by G1 but 
> was placed in SharedHeap. It was called from the G1CollectorPolicy 
> class, so I moved it to be next to the other related methods 
> (G1CollectorPolicy::print_heap_transition() and 
> G1CollectorPolicy::print_detailed_heap_transition()). I also renamed it 
> to print_heap_transition() to be more consistent with the other two 
> methods. Some simplifications to the parameter list could be made now 
> that it is an internal G1 method.

  looks good. Could you align the parameters of the
gclog_or_tty->print_cr() in print_heap_transition()?

I do not need another review for that.


More information about the hotspot-gc-dev mailing list