RFR: JDK-8076072 - parNew: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files

Stefan Karlsson stefan.karlsson at oracle.com
Fri Mar 27 10:01:40 UTC 2015


On 27/03/15 10:50, David Lindholm wrote:
> Hi Stefan,
>
> I have fixed this. Do you need a new webrev?

No. I'm OK with the patch if you fix the alignment.

Thanks,
StefanK
>
>
> Thanks,
> David
>
> On 2015-03-27 10:28, Stefan Karlsson wrote:
>> On 27/03/15 10:04, David Lindholm wrote:
>>> Hi,
>>>
>>> Please review this fix that removes the macro 
>>> PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC in gc files and fixes the gcc 
>>> warnings for the format strings. Some files had this macro even 
>>> though there were no warnings in them.
>>>
>>> This patch deals with all the parNew source files that had this macro.
>>>
>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8076072/webrev.00/
>>
>> http://cr.openjdk.java.net/~david/JDK-8076072/webrev.00/src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp.frames.html
>>
>> The alignment needs to be fixed:
>>   380           assert(sp->used_region().end() > used.end(),
>>   381                  err_msg("Expansion did not happen: "
>>   382                          "[" PTR_FORMAT "," PTR_FORMAT ") -> [" PTR_FORMAT "," PTR_FORMAT ")",
>>   383                          p2i(sp->used_region().start()), p2i(sp->used_region().end()),
>>   384                                                  p2i(used.start()), p2i(used.end())));
>>
>>
>> Thanks,
>> StefanK
>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076072
>>>
>>> Testing done: Passed JPRT
>>>
>>>
>>> Thanks,
>>> David
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150327/5989d7df/attachment.htm>


More information about the hotspot-gc-dev mailing list