RFR: JDK-8076071 - parallelScavenge: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files

David Lindholm david.lindholm at oracle.com
Fri Mar 27 13:01:02 UTC 2015


Stefan,

Thanks for the review.

/David

On 2015-03-27 11:00, Stefan Karlsson wrote:
> On 27/03/15 10:50, David Lindholm wrote:
>> Hi Stefan,
>>
>> I have fixed this. Do you need a new webrev?
>
> No. I'm happy with the patch if you fixed the alignment issues.
>
> Thanks,
> StefanK
>>
>>
>> Thanks,
>> David
>>
>> On 2015-03-27 10:24, Stefan Karlsson wrote:
>>> Hi David,
>>>
>>> On 27/03/15 09:52, David Lindholm wrote:
>>>> Hi,
>>>>
>>>> Please review this fix that removes the macro 
>>>> PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC in gc files and fixes the gcc 
>>>> warnings for the format strings. Some files had this macro even 
>>>> though there were no warnings in them.
>>>>
>>>> This patch deals with all the parallelScavenge source files that 
>>>> had this macro. There will be separate patches for the other 
>>>> collectors.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/
>>>
>>> http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp.udiff.html
>>>   418     gclog_or_tty->print_cr("Current region: [" PTR_FORMAT ", " PTR_FORMAT ") "
>>>   419       "New region: [" PTR_FORMAT ", " PTR_FORMAT ")",
>>>   420       p2i(s1->bottom()), p2i(s1->end()),
>>>   421           p2i(s1MR.start()), p2i(s1MR.end()));
>>>
>>>
>>> If you have to line break, could you align the parameters? Like:
>>>
>>>   418     gclog_or_tty->print_cr("Current region: [" PTR_FORMAT ", " PTR_FORMAT ") "
>>>   419       "New region: [" PTR_FORMAT ", " PTR_FORMAT ")",
>>>   420       p2i(s1->bottom()), p2i(s1->end()),
>>>   421       p2i(s1MR.start()), p2i(s1MR.end()));
>>>
>>> Thanks for fixing this!
>>>
>>> StefanK
>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076071
>>>>
>>>> Testing done: Passed JPRT
>>>>
>>>>
>>>> Thanks,
>>>> David
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150327/29935fb4/attachment.htm>


More information about the hotspot-gc-dev mailing list