RFR (S): JDK-8076225: Move the thread claim parity from SharedHeap to Thread
bengt.rutisson at oracle.com
Mon Mar 30 20:47:58 UTC 2015
On 30/03/15 22:33, Kim Barrett wrote:
> On Mar 30, 2015, at 3:21 PM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
>> Hi Kim,
>> Thanks for looking at this!
>> On 30/03/15 18:00, Kim Barrett wrote:
>>> On Mar 30, 2015, at 9:45 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
>>>> On 2015-03-30 15:40, Jesper Wilhelmsson wrote:
>>>>> Looks good.
>>>> Thanks, Jesper!
>>>>> I assume you count yourself as a Reviewer(?)
>>>> Yes, so unless anyone else looks at this and complains I'll push it tomorrow :)
>>> There’s a big comment in src/share/vm/memory/sharedHeap.hpp, preceding the location
>>> of the now removed strong_roots_parity(), which talks about the parity handling. It seems
>>> kind of misplaced now (though it is related to the StrongRootsScope). It also refers to the
>>> strong_roots_parity() function, which is being removed.
>> I absolutely agree. The comment needs to be placed (and probably re-written a bit) closer to where this code now exist.
>> The proposed patch is a step towards removing SharedHeap all together. The next step I am planning on is to move the StrongRootsScope handling out of SharedHeap. Would you be ok with me leaving the comment as it is now and postpone updating the comment to the StrongRootsScope patch? I'm convinced that I will need to work on the comments for that patch but I don't yet know exactly how it will end up.
> That’s mostly ok with me. But I’d like some kind of TBD comment added to the current change, in case of delays or distractions on that further cleanup. I don’t need another webrev to see such a comment though.
Great! Thanks! I'll add a TBD comment before I push.
More information about the hotspot-gc-dev