RFR (XS): 8078673: Update TEST.groups for recent GC tests

David Holmes david.holmes at oracle.com
Fri May 1 06:51:21 UTC 2015


Hi Derek,

On 1/05/2015 1:23 PM, Derek White wrote:
> On 4/30/15 2:33 AM, David Holmes wrote:
>> Hi Derek,
>>
>> On 29/04/2015 7:31 AM, Derek White wrote:
>>> Please review this simple for GC tests that require certain collectors
>>> (e.g. shouldn't run in embedded).
>>>
>>> Certain GC regression tests require specific collectors to be enabled in
>>> the JVM (by using -XX:+UseParallelGC, etc). But these tests were not
>>> listed in TEST.groups.
>>>
>>> This webrev adds the following tests to the appropriate needs_g1gc,
>>> needs_serialgc, needs_parallelgc, and needs_cmsgc lists.
>>>
>>>   * gc/TestSmallHeap.java
>>
>> I don't think it works correctly to have a test that requires multiple
>> GCs be listed in the needs_XXgc for each XX used. If I want to run
>> tests on a platform that only supports one GC then this will fail. I
>> think such tests should really only be in the needs_gc group. Further
>> I think the test will get excluded from all the applicable_YYgc group
>> if also in a needs_XXgc group.
>>
>> David
>
> Hi David,
>
> Just to confirm - you think I should add these tests to the needs_gc
> group, which currently is just a list of lists? Should there be a new
> list which means "needs all GCs"? Or is that what "needs_gc" means?

"needs_gc" seems to mean "these tests list an explicit gc requirement" 
and the "needs_XXgc" means "these tests list an explicit XXgc 
requirement", so if a test requires multiple gc's then either:

a) you need to define groups for needs_XXgc_and_YYgc for all 
permutations and add those to needs_gc; or
b) just add the tests directly to needs_gc

I'd suggest (b). But you may want to check the intent of whomever 
defined these in the first place.

Cheers,
David

> Thanks!
>
>   - Derek
>


More information about the hotspot-gc-dev mailing list