RFR (S): 8079091: Remove dictionary NULL check on common path of BlockFreeList methods

Stefan Karlsson stefan.karlsson at oracle.com
Mon May 4 07:24:23 UTC 2015


Hi Jon,

On 2015-05-01 15:45, Jon Masamitsu wrote:
>
>
> On 5/1/2015 6:38 AM, Jon Masamitsu wrote:
>> Jungwoo,
>>
>> Looks good.
>>
>> Reviewed.
>>
>> I'll sponsor it.
>>
>> Stefan had some questions about the performance numbers but
>> since it is a nice cleanup on it's own,  I'm going to go ahead and
>> push it.
>
> Having second thoughts on that.  Stefan did make a code change suggestion
> so should get a chance to look at that, but I'll handle it from here on.

I'm fine with the the 00 patch.

If you want to you could remove the assert:
-BlockFreelist::BlockFreelist() : _dictionary(NULL) {}
+BlockFreelist::BlockFreelist()
+    : _dictionary(new BlockTreeDictionary()) {
+  assert(_dictionary != NULL, "Failed to allocate BlockTreeDictionary");
+}

since it's not needed.

Thanks,
StefanK

>
> Jon
>
>>
>> Jon
>>
>>
>> On 4/30/2015 6:04 PM, Jungwoo Ha wrote:
>>>
>>>     >
>>>     > All,
>>>     >
>>>     > Let's go back to Jungwoo's 00 version.  It's a clean, limited
>>>     change.
>>>     >
>>>     > Objections?
>>>
>>>     That’s mostly ok with me.
>>>
>>>     I think the constructor and destructor suggestions that Stefan
>>>     and I made should be added.
>>>
>>>
>>> Done.
>>> http://cr.openjdk.java.net/~jwha/8079091/webrev.03 
>>> <http://cr.openjdk.java.net/%7Ejwha/8079091/webrev.03>
>>> Can you take a look?
>>> --Jungwoo
>>>
>>
>



More information about the hotspot-gc-dev mailing list