RFR (S): 8079091: Remove dictionary NULL check on common path of BlockFreeList methods

Stefan Karlsson stefan.karlsson at oracle.com
Mon May 4 17:04:42 UTC 2015


On 2015-05-04 18:15, Jungwoo Ha wrote:
> Stefan, this is already reflected on webrev.03. --Jungwoo

OK. I missed it since it was posted to hotspot-runtime-dev and this mail 
was sent to hotspot-gc-dev.

Anyways, webrev.03 looks good.

StefanK
>
>     If you want to you could remove the assert:
>     -BlockFreelist::BlockFreelist() : _dictionary(NULL) {}
>     +BlockFreelist::BlockFreelist()
>     +    : _dictionary(new BlockTreeDictionary()) {
>     +  assert(_dictionary != NULL, "Failed to allocate
>     BlockTreeDictionary");
>     +}
>
>     since it's not needed.
>
>     Thanks,
>     StefanK
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150504/e016c8ba/attachment.html>


More information about the hotspot-gc-dev mailing list