RFR(s): 8079330: Circular dependency between G1CollectedHeap and G1BlockOffsetSharedArray

Mikael Gerdin mikael.gerdin at oracle.com
Tue May 5 11:17:18 UTC 2015


Hi Per,

On 2015-05-05 12:11, Per Liden wrote:
> There's a circular include dependency between
> g1BlockOffsetTable.inline.hpp and g1CollectedHeap.inline.hpp. While
> working on a different change, which sorted the include lines in
> g1CollectedHeap.inline.hpp, this dependency was unveiled and caused a
> build error.
>
> This patch turns the check_index() macro in
> g1BlockOffsetTable.inline.hpp into a function and moves it to
> g1BlockOffsetTable.cpp.
>
> Webrev: http://cr.openjdk.java.net/~pliden/8079330/webrev.0/

Looks good.
Thanks for untangling this mess a bit.
/m

> Bug: https://bugs.openjdk.java.net/browse/JDK-8079330
>
> /Per


More information about the hotspot-gc-dev mailing list