RFR (XXS): 7006810: G1: Introduce peace-of-mind checking in the Suspendible Thread Set

Joseph Provino joseph.provino at oracle.com
Thu May 7 22:15:35 UTC 2015


Latest webrev is here:

http://cr.openjdk.java.net/~jprovino/7006810/webrev.05

It has Kim's change plus a request to use "!" instead of "== false".

Thanks.

joe

On 5/5/2015 9:12 PM, Kim Barrett wrote:
> On Apr 14, 2015, at 2:18 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>> On Apr 14, 2015, at 1:14 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>>> I made those changes:
>>>
>>> http://cr.openjdk.java.net/~jprovino/7006810/webrev.04/
>> Looks good.
> Just noticed one last nit -
>
> src/share/vm/gc_implementation/shared/suspendibleThreadSet.cpp
>    51   DEBUG_ONLY(Thread::current()->clear_suspendible_thread());
>
> The trailing semi-colon should be inside the DEBUG_ONLY().
>
> I don’t need a new webrev for that exchange of two characters.
>



More information about the hotspot-gc-dev mailing list