RFR (S): 8079208: gc/g1/TestLargePageUseForAuxMemory.java fails due to not considering page allocation granularity for setup

Thomas Schatzl thomas.schatzl at oracle.com
Wed May 13 22:19:36 UTC 2015


Hi Dmitry,

On Wed, 2015-05-13 at 18:57 +0300, Dmitry Fazunenko wrote:
> Hi Thomas,
> 
> The fix looks good.
> But I would like to ask you about minor improvement: provide more debug 
> info. Having values returned by wb methods in the jtr file will be useful.
> 
> Another thing I would ask you to do is to distinguish somehow testVM() 
> runs. After adding @ignore tag the line numbers were changed, so it's 
> not easy to restore from the stack trace which particular testVM call 
> caused the failure.
> Possible ways to do this:
> - print out the values of the parameters given
> - add a string parameter to describe expected behavior:
> 
>    void testVM(String what, ...) {
>        System.out.println(what);
>        ...
>    }
> 
>    testVM("case1: ...", ...);
>    testVM("case2: ...", ...);
> 
> The second way requires a bit more effort, but it will make logic of 
> this complicated test cleaner.

Okay, will do. Can you have a look at the other question raised in this
thread, is it somehow possible to make sure the test is run on a machine
set up with large page support?

Currently this test has a crude way of just skipping the test if there
is no large page support.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list