RFR (S): 8079208: gc/g1/TestLargePageUseForAuxMemory.java fails due to not considering page allocation granularity for setup

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Thu May 14 07:27:14 UTC 2015


Hi Thomas,

Thanks for taking my notes.
What about running the tests on hosts with pre-configured large pages, 
yes, it's possible but a bit tricky. Let's talk off line.

-- Dima


On 14.05.2015 01:19, Thomas Schatzl wrote:
> Hi Dmitry,
>
> On Wed, 2015-05-13 at 18:57 +0300, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
>> The fix looks good.
>> But I would like to ask you about minor improvement: provide more debug
>> info. Having values returned by wb methods in the jtr file will be useful.
>>
>> Another thing I would ask you to do is to distinguish somehow testVM()
>> runs. After adding @ignore tag the line numbers were changed, so it's
>> not easy to restore from the stack trace which particular testVM call
>> caused the failure.
>> Possible ways to do this:
>> - print out the values of the parameters given
>> - add a string parameter to describe expected behavior:
>>
>>     void testVM(String what, ...) {
>>         System.out.println(what);
>>         ...
>>     }
>>
>>     testVM("case1: ...", ...);
>>     testVM("case2: ...", ...);
>>
>> The second way requires a bit more effort, but it will make logic of
>> this complicated test cleaner.
> Okay, will do. Can you have a look at the other question raised in this
> thread, is it somehow possible to make sure the test is run on a machine
> set up with large page support?
>
> Currently this test has a crude way of just skipping the test if there
> is no large page support.
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list