RFR (S): 8079208: gc/g1/TestLargePageUseForAuxMemory.java fails due to not considering page allocation granularity for setup

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Tue May 19 12:47:57 UTC 2015


Hi Thomas,

The change looks good. It would look even better if the values of 
largePageSize, smallPageSize and allocGranulairty are printed out. 
Having their values in output will help to debug test failure.

Thanks,
Dima

On 19.05.2015 14:56, Thomas Schatzl wrote:
> Hi Dmitry,
>
> On Thu, 2015-05-14 at 10:27 +0300, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
>> Thanks for taking my notes.
>    added the requested output, printing some "caseX: some-description" at
> the start of the test run.
>
> Here is the new webrev:
> http://cr.openjdk.java.net/~tschatzl/8079208/webrev/
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8079208
>
> Unfortunately I just refreshed my mq patch, so I do not have diffs, also
> I accidently rsynced the new change over the old one.
>
> The change is really limited to adding the suggested parameter to the
> testVM() method, and adapting the calls.
>
>> What about running the tests on hosts with pre-configured large pages,
>> yes, it's possible but a bit tricky. Let's talk off line.
> Did that, no problems. I was more asking about a way to indicate that the test prefers to be run on such machines to jtreg though.
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list