RFR(xs): 8080584: isGCActiveMark.hpp should not include parallelScavengeHeap.hpp

Per Liden per.liden at oracle.com
Tue May 19 15:20:25 UTC 2015


On 2015-05-19 16:42, Kim Barrett wrote:
> On May 19, 2015, at 4:11 AM, Per Liden <per.liden at oracle.com> wrote:
>>
>> On 2015-05-19 02:11, Kim Barrett wrote:
>>> On May 18, 2015, at 10:31 AM, Per Liden <per.liden at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> This is a follow up patch to the GC directory restructure, which removes the unnecessary dependency between gc/shared/isGCActiveMark.hpp and gc/parallel/parallelScavengeHeap.hpp
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~pliden/8080584/webrev.0/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080584
>>>>
>>>> cheers,
>>>> /Per
>>>
>>> ------------------------------------------------------------------------------
>>> src/share/vm/gc/shared/isGCActiveMark.hpp
>>>    28 #include "memory/allocation.hpp"
>>>
>>> This file needs several more includes to be clearly standalone. It
>>> references at least the following:
>>>
>>> - CollectedHeap class
>>> - Universe class
>>> - assert macro
>>>
>>> I don't know if dealing with this is out of scope for this changeset,
>>> but mention it since the changes go beyond just eliminating the
>>> conditional dependency on parallelScavengeHeap.hpp.
>>>
>>
>> Good point. Here's an updated webrev, which includes all dependencies:
>>
>> http://cr.openjdk.java.net/~pliden/8080584/webrev.1/
>>
>> Thanks
>> /Per
>
> Looks good.
>

Thanks Kim.

/Per


More information about the hotspot-gc-dev mailing list