RFR(S): 8137756: Remove hrs_err_msg and hrs_ext_msg from heapRegionSet

David Lindholm david.lindholm at oracle.com
Mon Nov 2 13:33:43 UTC 2015


Per,

I fixed this. Thanks for the review!

/David

On 2015-11-02 12:43, Per Liden wrote:
> Hi David,
>
> On 2015-10-30 14:54, David Lindholm wrote:
>> Hi,
>>
>> Please review this follow-up patch to the varargs assert()-patch. This
>> patch deletes the hrs_err_msg and hrs_ext_msg from heapRegionSet.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8137756
>> Webrev: http://cr.openjdk.java.net/~david/JDK-8137756/webrev.00/
>
> heapRegionSet.cpp
> -----------------
>   32   assert_heap_region_set(hr->containing_set() == NULL, "should 
> not already have a containing set %u");
>
> The %u in there looks wrong.
>
> Other than that the change looks good. I don't need to see another 
> webrev just for this.
>
> cheers,
> /Per



More information about the hotspot-gc-dev mailing list