RFR: 8140602: Split other time calculation into methods in G1CollectorPolicy

Mikael Gerdin mikael.gerdin at oracle.com
Mon Nov 2 14:46:50 UTC 2015


Hi Erik,

On 2015-11-02 11:09, Erik Helin wrote:
> All,
>
> after reading through this patch again I noticed that I made the wrong
> calculations in G1CollectorPolicy::other_time_ms (I was caclulating
> "known time", not "other time"). Please see updated webrevs:
>
> - Full:
>    http://cr.openjdk.java.net/~ehelin/8140602/webrev.01/
> - Incremental:
>    http://cr.openjdk.java.net/~ehelin/8140602/webrev.00-01/

Looks good.
/Mikael

>
> Thanks,
> Erik
>
> On 2015-10-27, Erik Helin wrote:
>> Hi all,
>>
>> this small patch extracts the other time calculations in
>> G1CollectorPolicy into separate methods. The code becomes shorter and
>> easier to read.
>>
>> Enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8140602
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8140602/webrev.00/
>>
>> Thanks,
>> Erik



More information about the hotspot-gc-dev mailing list