RFR (XS): 8141134: Remove unnecessary pragma warning(disable:4355) from GC code

Thomas Stüfe thomas.stuefe at gmail.com
Tue Nov 3 14:32:04 UTC 2015


Hi,

one question, does this mean this would not build anymore with Visual
Studio 2010?

According to :
https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms ,
VS2010 is still supported build platform.

Also there seems to be enough interest in the community about keeping the
VS2010 build alive, see
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-October/015978.html

We (SAP) unfortunately still use Visual Studio 2010 for our VM, it would be
nice if that would continue to work.

Best Regards, Thomas



On Mon, Nov 2, 2015 at 5:17 PM, Erik Helin <erik.helin at oracle.com> wrote:

> On 2015-11-02, Thomas Schatzl wrote:
> > Hi all,
> >
> >   Erik H. made me aware of another pragma 4355 in nmethod.cpp that can
> > be removed.
> >
> > I updated the webrev in place because of the kind of change.
>
> Looks good, Reviewed.
>
> > Thanks,
> >   Thomas
> >
> > On Mon, 2015-11-02 at 16:14 +0100, Thomas Schatzl wrote:
> > > Hi all,
> > >
> > >   can I have reviews for the following change that removes some pragmas
> > > in GC code?
> > > With the move to newer MSVC, they are not needed any more.
> > >
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8141134
> > > Webrev:
> > > http://cr.openjdk.java.net/~tschatzl/8141134/webrev/
> > > Testing:
> > > jprt
> > >
> > > Thanks,
> > >   Thomas
> > >
> > >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151103/8a353a86/attachment.html>


More information about the hotspot-gc-dev mailing list