RFR (XS): 8141134: Remove unnecessary pragma warning(disable:4355) from GC code

Volker Simonis volker.simonis at gmail.com
Wed Nov 4 15:16:28 UTC 2015


Hi Thomas,

the change looks good. Thomas St. is just checking the VS2010 build.
We'll let you new the results once it's finished.

Thank you and best regards,
Volker


On Wed, Nov 4, 2015 at 4:04 PM, Erik Helin <erik.helin at oracle.com> wrote:
> On 2015-11-04, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote:
>> > Hi Erik,
>> >
>> > thanks a lot for your understanding :)
>> >
>> > Your suggestion is perfectly fine for me and we can live with both
>> > versions of the fix.
>>
>>   I went for the change in the globalDefinitions* file.
>>
>> New webrevs:
>> http://cr.openjdk.java.net/~tschatzl/8141134/webrev.1/
>> http://cr.openjdk.java.net/~tschatzl/8141134/webrev.0_to_1/
>
> Looks good to me, Reviewed.
>
>> It built fine on the official MS compiler, but I did not check on VS
>> 2010.
>
> Volker, can you check if this compiles on VS 2010?
>
> Thanks,
> Erik
>
>> Thanks,
>>   Thomas
>>
>>


More information about the hotspot-gc-dev mailing list