RFR(M): 8139867: Change how startsHumongous and continuesHumongous regions work in G1.

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 5 13:47:15 UTC 2015


Hi David,

On Thu, 2015-11-05 at 14:00 +0100, David Lindholm wrote:
> Tom,
> 
> Thanks for your comments!
> 
> On 2015-11-04 22:49, Tom Benson wrote:
> > Hi David,
> > Thanks for updating that.   My only other comments are pretty trivial.
> >
[...]
> > g1CollectedHeap.hpp/cpp and heapRegionManager.hpp/cpp:
> >
> > Could next_humongous_region be called next_region_in_humongous (or 
> > perhaps, humongous_object_continuation) to clarify it isn't just the 
> > next humongous region in the heap, but a continuation of the current 
> > humongous object?  I know, it's hard to get too excited by that...
> 
> Yes, you are correct. Changed to next_region_in_humongous instead.
> 
> Tom and Thomas, could you both please look at the latest webrev:
> 
> http://cr.openjdk.java.net/~david/JDK-8139867/webrev.04/
> http://cr.openjdk.java.net/~david/JDK-8139867/webrev.03-04/ (diff)
> 

  still looks good.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list