RFR(S): 8141356: Explicitly stop CMS threads during VM termination.

Jungwoo Ha jwha at google.com
Thu Nov 5 19:44:33 UTC 2015


Thank you so much for the review, Jon. --Jungwoo

On Thu, Nov 5, 2015 at 8:00 AM, Jon Masamitsu <jon.masamitsu at oracle.com>
wrote:

> Jungwoo,
>
> Change looks good.  I'll sponsor.
>
> I'll need to get 1 more review.
>
> Jon
>
> On 11/03/2015 01:14 PM, Jungwoo Ha wrote:
>
> BUG: https://bugs.openjdk.java.net/browse/JDK-8141356
> Webrev: http://cr.openjdk.java.net/~jwha/8141356/webrev.00/
>
> Inside before_exit(), it says
>
>   // Stop concurrent GC threads
>   Universe::heap()->stop();
>
> but GenCollectedHeap never implemented stop() method, and thus calling
> empty SharedHeap::stop() method.
> This causes CMS threads to run during the VM termination and ends up
> crashing.
> ConcurrentMarkSweepThread::stop() is currently a dead code and never gets
> called.
> The patch just implemented GenCollectedHeap::stop() to call
> ConcurrentMarkSweepThread::stop().
>
> Can someone sponsor this patch?
>
> --
> Jungwoo Ha | Google | jwha at google.com
>
>
>


-- 
Jungwoo Ha | Java Platform Team | jwha at google.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151105/7bfa871d/attachment.html>


More information about the hotspot-gc-dev mailing list