RFR (S): 8136679: JFR Event for adaptive IHOP

sangheon.kim sangheon.kim at oracle.com
Fri Nov 6 00:17:14 UTC 2015


Hi Thomas,

Overall looks good.
I have pretty trivial comments.

============================
http://cr.openjdk.java.net/~tschatzl/8136679/webrev/src/share/vm/gc/shared/gcTraceSend.cpp.frames.html

273 size_t last_allocation_ize,

Typo of last_allocation_size.

============================
http://cr.openjdk.java.net/~tschatzl/8136679/webrev/src/share/vm/gc/shared/gcTrace.hpp.frames.html

263 void report_adaptive_ihop_statistics(size_t additional_buffer_size,
264 double predicted_allocation_rate,
265 double predicted_marking_length,
266 bool prediction_active);

Wrong indentation.

============================
http://cr.openjdk.java.net/~tschatzl/8136679/webrev/src/share/vm/gc/shared/gcTraceSend.cpp.frames.html

281 evt.set_thresholdPercentage(threshold * 100.0 / target_occupancy);

Q) Is always 'target_occupancy > 0' ?

Thanks,
Sangheon


On 11/05/2015 01:58 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this change that adds a JFR event for adaptive
> IHOP?
>
> The change provides the same information as the IHOP related log
> messages as JFR events.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8136679
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8136679/webrev/
> Testing:
> jprt, new (basic) jtreg test
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list