RFR: 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions

Bengt Rutisson bengt.rutisson at oracle.com
Sun Nov 8 12:47:54 UTC 2015


Hi Kim,

On 2015-11-07 22:09, Kim Barrett wrote:
> Please review this fix of a couple of tests that use diagnostic
> options without also providing -XX:+UnlockDiagnosticVMOptions.
>
> CR:
> 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions
>
> Webrev:
> 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions

I assume this is the correct webrev link?
http://cr.openjdk.java.net/~kbarrett/8141654/webrev.00/

In that case it looks good.

Not sure that it is such a great idea that UnlockDiagnosticVMOptions is 
true in debug builds. It kind of encourages mistakes like this. But that 
is a different story.

Thanks,
Bengt

>
> Testing:
> JPRT, local jtreg testing.
>
>



More information about the hotspot-gc-dev mailing list