RFR: JDK-8142475: Remove TraceParallelOldGCTasks

Bengt Rutisson bengt.rutisson at oracle.com
Wed Nov 11 14:03:34 UTC 2015


Hi Thomas,

On 2015-11-11 15:00, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2015-11-11 at 13:46 +0100, Bengt Rutisson wrote:
>> Hi all,
>>
>> Could I have a couple of reviews for this change?
>>
>> https://bugs.openjdk.java.net/browse/JDK-8142475
>> http://cr.openjdk.java.net/~brutisso/8142475/webrev.00/
>>
>> The ParallelGC has logging in debug builds (even if it is guarded by a
>> product flag) that logs messages for each task.
>>
>> The output from this logging i pretty scrambled and hard to make sense
>> of. Each thread prints the task it is currently working on. There is no
>> correlation between threads and there is no summary to add times for
>> related tasks.
>>
>> This type of per thread information is hard to make useful in a log
>> file. It would be much better to add trace events for this information.
>>
>> Rather than trying to fix this logging we should remove it. If it turns
>> out that it is needed in the future we should add trace events to track it.
>    removal is fine with me. Looks good.

Thanks for looking at this!

Bengt

>
> Thomas
>
>



More information about the hotspot-gc-dev mailing list