RFR: 8142404: Parallelize the restoring of preserved marks

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 12 10:24:19 UTC 2015


Hi,

On Thu, 2015-11-12 at 11:16 +0100, Erik Helin wrote:
> Hi all,
> 
> this patch parallelizes the restoring of the preserved marks after an
> evacuation failure.
> 
> Enhancement:
> https://bugs.openjdk.java.net/browse/JDK-8142404
> 
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8142404/webrev.00/
> 
> Testing:
> - JPRT
> - gc-test-suite with VerifyBeforeGC, DuringGC, AfterGC

  looks good.

Could you please

- add comments to the new method declarations in G1CollectedHeap? Also I
find the newline between remove_self_forwarding_pointers() and
restore_preserved_marks() a bit strange, I would expect them to be
grouped together, not restore_after_evac_failure() and
restore_preserved_marks.

- regularize newlines between the constructor and the work method for
G1ParRemoveSelfForwardPtrsTask and G1RestorePreservedMarksTask?

Thanks for moving OopAndMarkOop.

I do not need a re-review for these changes.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list