RFR: 8142404: Parallelize the restoring of preserved marks

Erik Helin erik.helin at oracle.com
Thu Nov 12 11:10:24 UTC 2015


On 2015-11-12, Thomas Schatzl wrote:
> Hi,
> 
> On Thu, 2015-11-12 at 11:16 +0100, Erik Helin wrote:
> > Hi all,
> > 
> > this patch parallelizes the restoring of the preserved marks after an
> > evacuation failure.
> > 
> > Enhancement:
> > https://bugs.openjdk.java.net/browse/JDK-8142404
> > 
> > Webrev:
> > http://cr.openjdk.java.net/~ehelin/8142404/webrev.00/
> > 
> > Testing:
> > - JPRT
> > - gc-test-suite with VerifyBeforeGC, DuringGC, AfterGC
> 
>   looks good.

Thanks!

> Could you please
> 
> - add comments to the new method declarations in G1CollectedHeap? Also I
> find the newline between remove_self_forwarding_pointers() and
> restore_preserved_marks() a bit strange, I would expect them to be
> grouped together, not restore_after_evac_failure() and
> restore_preserved_marks.

Sure, done.

> - regularize newlines between the constructor and the work method for
> G1ParRemoveSelfForwardPtrsTask and G1RestorePreservedMarksTask?

Fixed as well.

> Thanks for moving OopAndMarkOop.

No problem :)

> I do not need a re-review for these changes.

Since I need an additional review anyway, I uploaded the changes:
- incremental:
http://cr.openjdk.java.net/~ehelin/8142404/webrev.00-01/
- full:
http://cr.openjdk.java.net/~ehelin/8142404/webrev.01/

Thanks,
Erik

> Thanks,
>   Thomas
> 
> 


More information about the hotspot-gc-dev mailing list