Request for code review - JDK-8141135,Remove G1RemSet::write_ref

Kim Barrett kim.barrett at oracle.com
Thu Nov 12 16:11:43 UTC 2015


On Nov 12, 2015, at 10:06 AM, David Lindholm <david.lindholm at oracle.com> wrote:
> 
> Yes, but the surrounding code (including the assert() we discussed) is rebased.

Ah, that was subtle.

> On 2015-11-12 16:00, Kim Barrett wrote:
>> On Nov 11, 2015, at 11:30 AM, Alexander Harlap <alexander.harlap at oracle.com> wrote:
>>> Here is change merged with David's change for JDK-8139867:
>>> 
>>> http://cr.openjdk.java.net/~aharlap/8141135/webrev.01 <http://cr.openjdk.java.net/%7Eaharlap/8141135/webrev.01>
>>> 
>>> Now it satisfies to Kim's comments ( no more wrongful / confusing assumptions that "from" inside of par_write_ref might be NULL )
>> webrev.01 appears to be the same as webrev.00 ?

webrev.01 looks good.



More information about the hotspot-gc-dev mailing list