RFR: 8143014: Access PtrQueue member offsets through derived classes

Kim Barrett kim.barrett at oracle.com
Mon Nov 16 08:29:42 UTC 2015


On Nov 16, 2015, at 3:15 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> On Sun, 2015-11-15 at 15:39 -0500, Kim Barrett wrote:
>> Please review this cleanup of the API for accessing member offset
>> information for SATBMarkQueue and DirtyCardQueue.  Clients now access
>> the specific queue class information.  In addition, JVMCI now uses the
>> same API for obtaining the information as is used by other compilers
>> and interpreters.
>> 
>> Also moved the vmStruct declarations for PtrQueue and members to
>> vmStructs_g1.hpp, as that class is G1-specific.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8143014
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/
>> 
>> Testing:
>> JPRT
> 
>  looks good to me, but could you do at least some simple test run with
> the SA agent, or run the vm.gc testlist before pushing?
> 
> JPRT is not enough to check for problems in the SA agent.

Good point.  Will do.



More information about the hotspot-gc-dev mailing list